Clarify environments #24279
Merged
Clarify environments #24279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using capitalizeed "Cloudflare Environments" is a bit confusing since it's not a named product
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
|
Preview URL: https://f821348f.preview.developers.cloudflare.com Files with changes (up to 15) |
anonrig
approved these changes
Aug 9, 2025
petebacondarwin
approved these changes
Aug 9, 2025
There was a problem hiding this comment.
"Environments" is so overloaded. There are at least three different types: Cloudflare environments (these), Process environments (e.g. process.env), Vite environments (aka modes). In the Vite docs we call the first Cloudflare Environments.
But happy to remove that here.
kodster28
approved these changes
Aug 12, 2025
thomasgauvin
pushed a commit
that referenced
this pull request
Aug 15, 2025
Using capitalizeed "Cloudflare Environments" is a bit confusing since it's not a named product
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using capitalizeed "Cloudflare Environments" is a bit confusing since it's not a named product